Re: Multithread heap assertion failure(Continued)

"Zhiguo" <ZhiguoYoung@gmail.com> ha scritto nel messaggio
news:1186712161.037642.210720@d30g2000prg.googlegroups.com...


Hi Zhiguo,

I've built your code and the same error happens to me.

However, I think that the problem may be due to the "malformed" MFC app
defined into your source code.

In fact, reading your source, I did neither find a definition for MFC global
application object "CWinApp theApp", nor a call to AfxWinInit.
Why did not you use the MFC wizard to build the skeleton code, so you could
have a safe start to insert your own code into?

I refactored your code, putting it into the MFC wizard skeleton created
code, renaming your main() function as MainTest() (in fact, the main()
function skeleton is produced by the wizard), and everything seems fine (no
assertions thrown).

Just before posting the working code, I would like to suggest you to not use
old-style C/C++ arrays; you must pay attention to remember to delete them,
and they are not bounds-checked. You may want to use better and more robust
container classes like std::vector, e.g.:

instead of:

  HANDLE * m_pThreadHandle = new HANDLE[nWorkerNum];
  ...
  ... lots of code
  ...
  delete [] m_pThreadHandle;

you might use:

  std::vector< HANDLE > threadHandles;

  threadHandles.push_back( handle1 );
  threadHandles.push_back( handle2 );
  ...
  ...

And the threadHandles vector is automatically destroyed.

Here's the working code:

<CODE>

// TestMultithread.cpp : Defines the entry point for the console
application.
//

#include "stdafx.h"
#include "TestMultithread.h"
#ifdef _DEBUG
#define new DEBUG_NEW
#endif

//
// *** Original main skeleton generated by Wizard ***
//
//// The one and only application object
//
//CWinApp theApp;
//
//using namespace std;
//
//int _tmain(int argc, TCHAR* argv[], TCHAR* envp[])
//{
// int nRetCode = 0;
//
// // initialize MFC and print and error on failure
// if (!AfxWinInit(::GetModuleHandle(NULL), NULL, ::GetCommandLine(), 0))
// {
// // TODO: change error code to suit your needs
// _tprintf(_T("Fatal Error: MFC initialization failed\n"));
// nRetCode = 1;
// }
// else
// {
// // TODO: code your application's behavior here.
// }
//
// return nRetCode;
//}

#include <afx.h>
#include <afxmt.h>
#include <afxwin.h> // MFC core and standard components
#include <windows.h>

#include <iostream>
using namespace std;

class CTestThread: public CWinThread{
public:
    long timeout;

    CTestThread(){}
    virtual ~CTestThread(){}

    int Run(){
        cout << "run..." << endl;
        Sleep(timeout);
        return 1;
    }

    BOOL InitInstance(){
        cout << "init..." << endl;
        return TRUE;
    }

    int ExitInstance(){
        cout << "exit inst..." << endl;
        return 0;
    }
};

//
// *** Your main redefined as MainTest() ***
//
void MainTest(){
    int nWorkerNum = 2;
    CTestThread * m_pThread = new CTestThread[nWorkerNum];
    HANDLE * m_pThreadHandle = new HANDLE[nWorkerNum];
    for(int i = 0; i < nWorkerNum; i ++){
        m_pThread[i].CreateThread();
        m_pThread[i].m_bAutoDelete = FALSE;
        m_pThreadHandle[i] = m_pThread[i].m_hThread;
    }
    m_pThread[0].timeout = 1;
    m_pThread[1].timeout = 3000;
    WaitForMultipleObjects(nWorkerNum, m_pThreadHandle, FALSE, INFINITE);
    cout << "here" << endl; cout.flush();
    clock_t s = clock();
    WaitForMultipleObjects(nWorkerNum, m_pThreadHandle, TRUE, 2500);
    clock_t e = clock();
    cout << "####" << (e - s) << endl;
    cout << "there" << endl; cout.flush();

    for(int i = 0; i < nWorkerNum; i ++){
        m_pThread[i].ExitInstance();
    }

    delete [] m_pThreadHandle;
    delete [] m_pThread;

    cout << "Press c to conitnue..." << endl;
    cout.flush();
    char c; cin >> c;
}

// The one and only application object

CWinApp theApp;

using namespace std;

int _tmain(int argc, TCHAR* argv[], TCHAR* envp[])
{
    int nRetCode = 0;

    // initialize MFC and print and error on failure
    if (!AfxWinInit(::GetModuleHandle(NULL), NULL, ::GetCommandLine(), 0))
    {
        // TODO: change error code to suit your needs
        _tprintf(_T("Fatal Error: MFC initialization failed\n"));
        nRetCode = 1;
    }
    else
    {
        // TODO: code your application's behavior here.
        MainTest();
    }

    return nRetCode;
}

</CODE>

Giovanni