Re: Is there a convention mandating macros to be all-uppper-case?

From:

Ulrich Eckhardt <eckhardt@satorlaser.com>

Newsgroups:

microsoft.public.vc.language

Date:

Mon, 22 May 2006 16:52:37 +0200

Message-ID:

<mqv8k3-url.ln1@satorlaser.homedns.org>

ultranet wrote:

"Ulrich Eckhardt" wrote:

I may add that the (very good!) book "C++ Coding Standards" by Sutter and
Alexandrescu suggest that a) all macros are uppercase and b) only macros
are uppercase for that very reason. However, there is existing practice
to make constants from both constant objects and enumerations all
uppercase and assert() isn't uppercase either, although it should.

How would you change the following enum?

enum eMyEnum {
eINVOKE,
eINVOKE_AND_WAIT
};

namespace call
{
  enum type
  {
    invoke,
    invoke_and_wait
  };
}

call::type t = call::invoke_and_wait;

I'd like to make it clear that each constant is an enum member, by using
EINVOKE would look like an error. I'm not sure about standard headers, but
in other headers i see some like above, and some all-cap, w/o e, like
INVOKE.

If you were to follow standard headers, you would call all identifiers _Foo
or __bar. Not everything you see in standard headers is applicable to your
code, these headers have to do it because they must still work when someone
#defines foo 1 or #defines bar 42 (or, for that matter, 'i', 'it', 'x', 'y'
or whatever other stuff is commonly used).

Uli