Re: Quick question on object instantiation!
Robby wrote:
In Windows programming, is it bad practice or uncommon to instatiate
an object outside WndProc and then using the object in WndProc.
Don't know how [un]common this is, but I've used it (or, rather, some
variation of it).
Please consider the following code:
===========================================
class Shape
{
public:
Shape(); //Default constructor
Shape(Shape&); //Copy constructor
~Shape(); //Destructor
int GetCounter() const {return iCounter;}
void operator++();
private:
int iCounter;
};
Shape *pShape = new Shape; //Object instatiated outside WndProc
I usually make it 'static' and place it inside the 'WndProc' itself.
Then there is much less temptation to try to change it (or access it)
from some other function.
LRESULT CALLBACK WndProc(HWND hwnd, UINT message,
WPARAM wParam, LPARAM
lParam) {
WM_PAINT:
pShape->SetTitles(hdc,rect); //Object now manipulated in WndProc
return 0;
case WM_DESTROY:
delete pShape; //Object deleted only when I exit
application
That's fine. My usual stuff wasn't necessarily in a global WndProc,
but in some other Procs, usually DlgProc. The main thing is not to
forget to set it to 0 after deletion (just in case).
PostQuitMessage(0);
return 0;
.....WndProc code.....
}
===================================================
The thing is that, I would like my object to stay in scope as long as
my program is running. However if I instantiate my object in WndProc,
then every time I return from a handler within my WndProc function, I
loose the data stored in the members of my class. So I figure if I
instantiate it outside WndProc, the class members would be
preserved.... right or not?
Declare the pointer 'static' and place it _inside_ WndProc.
I just would like to know if this type of coding is acceptable in
VC++?
As long as it serves your needs, who's to tell you that it isn't?
V
--
Please remove capital 'A's when replying by e-mail
I do not respond to top-posted replies, please don't ask