I don't think auto sizing a static control would have this kind of problem.
If it was me I wouldn't try to break the string myself. I would decide on a
"Joseph M. Newcomer" <newcomer@flounder.com> wrote in message
This is sort of a classic problem. If it is too big, you make it smaller,
and if it is
too small, you make it bigger, but ultimately you need to converge. I
made this mistake
some years ago in a CScrollView. If the line was too long, I enabled the
horizontal
scrollbar. If all lines fit, I hid the horizontal scroll bar. This
worked fine until the
horizontal scroll bar hid the longest line. So it was turned off and
everything redrew.
Now no line was too long, so I could hide the scroll bar, and now the last
line was too
long.
Overall, this code seems very complex. For example, the rule about not
breaking a word
depends upon the fact that space is a possible delimiter; this may not
always be so. And
there are issues about what is a "word", would you want to break
hyphenated-phrase at the
hyphen, for example?
joe
On Tue, 19 Jun 2007 18:18:00 +0200, mosfet <john.doe@anonymous.org> wrote:
HI,
I would like to write a CStatic that automatically resize itself
according to its content.
in my code when I detect my control is too small (nDiff < 0 in my code)
I call SetWindowPos but when I do that I enter an infinite loop and my
Cxstatic draw some nice stairs.
How can I fix that ?
void CxStatic::DrawText(CDC* pDCMem, CRect* pRect, CString csText)
{
DWORD dwStyle = m_dwTxtFlags;
DWORD dwFlags = 0;
MAP_STYLE( SS_RIGHT, DT_RIGHT );
MAP_STYLE( SS_CENTER, DT_CENTER );
MAP_STYLE( SS_LEFT, DT_LEFT );
//MAP_STYLE( SS_CENTERIMAGE, DT_VCENTER | DT_SINGLELINE );
MAP_STYLE( SS_NOPREFIX, DT_NOPREFIX );
// MAP_STYLE( SS_WORDELLIPSIS, DT_WORD_ELLIPSIS );
MAP_STYLE( SS_ENDELLIPSIS, DT_END_ELLIPSIS );
// MAP_STYLE( SS_PATHELLIPSIS, DT_PATH_ELLIPSIS );
// TAb expansion
if (csText.Find( _T('\t') ) != -1)
dwFlags |= DT_EXPANDTABS;
//csText.Replace(
// TEXT WRAPPING - Inspired by Chen-Cha Hsu and improved
CRect newRC;
TEXTMETRIC tag;
CSize sz;
::GetTextExtentPoint32(pDCMem->GetSafeHdc(), csText,csText.GetLength(),
&sz);
CStringArray asText;
int nLine = 0;
CString s2;
int nX = 0;
int nId = 0;
TCHAR nCR = 0;
// Autowrapping mode enabled
if ( m_bAutoWrapping ){
for (int i = 1; i <= csText.GetLength(); i++){
s2 = csText.Left(i);
//CARRIAGE RETURN not recognised with SS_CENTERIMAGE - manual handling
if (csText.GetAt(i-1) == '\r' || csText.GetAt(i-1) == '\n'){
if (nCR == 0){
nCR = csText.GetAt(i-1);
}
else if (nCR != csText.GetAt(i-1)){ // "\r\n" or "\n\r"
s2 = csText.Left(i-2);
asText.Add(s2);
csText = csText.Mid(i);
i = nCR = 0;
}
}
::GetTextExtentPoint32(pDCMem->GetSafeHdc(), s2, s2.GetLength(), &sz);
*****
CDC::GetTextExtent should do the job perfectly well. Note that
CDC::GetTextExtent calls
GetTextExtentPoint32!
***
if ( sz.cx > pRect->Width() ){// We found how many letters fits
s2 = csText.Left(i-1);
if ( IsASingleWord(s2) ){
asText.Add(s2);
csText = csText.Mid(i-1);
i = 0;
}
else{ // Do not break a word
nId = s2.ReverseFind(' ');
*****
Are you guaranteed that there really is a preceding space?
It looks like the asText is an array of words. What if there are multiple
spaces between
words? Do you need to preserve spacing?
*****
s2 = s2.Left(nId);
asText.Add(s2);
csText = csText.Mid(nId + 1);
i = 0;
}
}
}
if ( ! csText.IsEmpty() )
asText.Add(csText);
}
else{// Standard CStatic behaviour
asText.SetAtGrow(0, csText);
}
*****
This seems to be an unnecessarily complex loop for simply parsing words.
I would probably
not use anything like this (but I'm lazy), I'd let some API do it all for
me in one big
rush.. But I don't know quite what you're really trying to do here...the
intention is
swamped by the code volume.
*****
nLine = asText.GetSize();
pDCMem->GetTextMetrics(&tag);
newRC = *pRect;
LONG nTextHeight = tag.tmHeight * nLine;
LONG nDiff = (pRect->bottom - pRect->top) - (nTextHeight);
*****
OK, it seems that this is saying, is the static control too short to hold
all the lines?
*****
if (dwStyle & SS_CENTERIMAGE)
pRect->top = nDiff/2;
*****
And if it is negative does this matter that it will be clipped?
*****
//TRACE( "The value of nDiff is %d\n", nDiff );
if (m_bAutoAdjustFont){
if (nDiff < 0){
//SetWindowPos(NULL, 0,0, pRect->Width(), nTextHeight,
SWP_NOMOVE|SWP_NOZORDER|SWP_NOACTIVATE);
****
And this is what triggers the infinite loop? If the control has a border,
you might have
to compare the difference between GetWindowRect size and GetClientRect
size and note that
SetWindowPos adjusts the WINDOW rect size, which may still leave you with
a CLIENT size
that is too small. Look at CWnd::CalcWindowRect, which should do this for
you. Once
you've computed the client size, compute the window size required to hold
that client
size. I think this might be where your problem is.
*****
//Notify parent
}
//pDCMem->SelectObject( m_pFont ); TODO CHECK WITH AUTOADJUST
//RedrawWindow();
}
*****
Auto-adjusting fonts gets tricky because of the roundoff errors for small
font values (<20
units high), so you might need to write a converging algorithm. I just
did this
yesterday, and it was a real pain to deal with.
*****
for (int j = 0; j < nLine; j++){
newRC.top = pRect->top + tag.tmHeight * j;
*****
Generally, you want to use tmHeight+tmInternalLeading to get good line
spacing
*****
pDCMem->DrawText(asText[j], &newRC,dwFlags);
*****
At this point you've done enough work that a simple TextOut should suffice
*****
//DrawTextEx(pDCMem->GetSafeHdc(), asText[j],
asText[j].GetLength(),&newRC, dwFlags|DT_END_ELLIPSIS);
if (m_bFont3d){
if (m_3dType == Raised)
newRC.OffsetRect(-1,-1);
else
newRC.OffsetRect(1,1);
//DrawTextEx(pDCMem->GetSafeHdc(), asText[j],
asText[j].GetLength(),&newRC, dwFlags|DT_END_ELLIPSIS);
****
Code is more readable if you put spaces around operators, especially |,
which (depending
on the font) can be confused with I or l. so dwFlags | DT_END_ELLIPSIS is
easier to parse
visually. Nobody cares if the compiler can parse it correctly, if the
reader cannot.
****
pDCMem->DrawText(asText[j], &newRC,dwFlags);
}
}
}
Joseph M. Newcomer [MVP]
email: newcomer@flounder.com
Web: http://www.flounder.com
MVP Tips: http://www.flounder.com/mvp_tips.htm