Re: STL algorithm member function problem

  struct remove_by_rule
   {
      std::vector<std::string> &fileList;
      remove_by_rule(std::vector<std::string> &a):fileList(a){}
      void operator () (RulePtr p)
      {
         fileList.erase
         (
            std::remove_if(fileList.begin(),fileList.end(),*p),
            fileList.end()
         );
      }
   };

   int main()
   {
      // ...
      std::for_each(m_rules.begin(),m_rules.end(),
         remove_rule(fileList) );
      // ...
   }

  easier to read in my opinion and avoids explicitly naming iterator
types for iterators local to the loops actually performed. Holding
a non constant reference in the functor remove_by_rule assures the
same vector will be used no matter how many copies of remove_by_rule
are preformed and those copies will be 'cheap'. It also avoids copying
after the for_each() is performed.