Re: Reentrancy issue

From:

"Scott McPhillips [MVP]" <org-dot-mvps-at-scottmcp>

Newsgroups:

microsoft.public.vc.mfc

Date:

Tue, 22 Jan 2008 08:57:44 -0500

Message-ID:

<uc80J7PXIHA.3940@TK2MSFTNGP05.phx.gbl>

"mosfet" <john.doe@anonymous.org> wrote in message
news:4795f1bf$0$4790$426a74cc@news.free.fr...

Hi,

I am using a small singleton class called ResManager to handle my
resources in MFC .

One of its method is defined as shown below :

CString& ResManager::GetResText(int a_ResId)
{
BOOL bRet = m_strResText.LoadString( m_hResInst , a_ResId );
if (bRet == FALSE) {
WRITE2LN_LOG( "UIManager::GetResText : Cannot Load TEXT res with id ",
a_ResId);
m_strResText.Empty();
}
return m_strResText;
}

The problem is when I call it like this :

CString strTmp;
strTmp.Format(_T("%s<BR><BR><a href=\"%s\">%s</a>"),
ResManager::Get()->GetResText(IDS_A),
ResManager::Get()->GetResText(IDS_B),
ResManager::Get()->GetResText(IDS_C));

the formatted string is not good.

How can I solve this ?

You are trying to hold 3 different strings in one CString variable,
m_strResText.
One solution is to have GetResText return a CString instead of a CString&.

--
Scott McPhillips [VC++ MVP]