truly awesomely bad. Is that a double negative?
"Joseph M. Newcomer" <newcomer@flounder.com> wrote in message
It is normal to see a bit of mouse movement after a click/ But this code
is truly
awesomely bad. You should not have any message loop inside the
LButtonDown handler!
joe
On 19 Mar 2007 00:02:35 -0700, "vicky" <ziashahid123@gmail.com> wrote:
Hi All!
I am having a problem regarding mouse capture. I am capturing mouse
events in my LBUTTONDOWN Handler but i am unable to differ between
click (Mouse down and UP) and drag(Mouse down -> move -> up).
When i am expecting single click windows fires mouse move too. at
first time it runs fine but for subsequent clicks it gives me msg
"Mouse L-Button UP, After Mouse Move.".
What to do now?
Following is my code in which i am capturing mouse events on
LBUTTONDOWN handler.
void CMouseCaptureView::OnLButtonDown(UINT nFlags, CPoint point)
{
CPoint pt;
****
Starting here and continuing to "end of for", DELETE ALL THIS CODE!
This code belongs in the OnMouseMove handler! And there should be no
WM_TIMER handler at
all!
THis code is simply WRONG. The fact that you are switching the capture is
seriously bad.
The classic drag code looks like
void CMyClass::OnLButtonDown(...)
{
SetCapture();
}
void CMyClass::OnMouseMove(...)
{
if(GetCapture() != NULL)
{ /* dragging */
... drag logic here
} /* dragging */
}
void CMyClass::OnLButtonUp(...)
{
if(GetCapture() != NULL)
ReleaseCapture();
}
Whatever you do should fit the above paradigm. Nesting your own
GetMessage loop as you
have done would not make sense in raw Win32 programming, let alone in MFC.
Since you want to know if the mouse has been dragging longer than a
specific time, you can
just do a SetTimer() in the LButtonDown handler and issue notifications
when you get the
timer notification, providing you still have capture.
THis code is so remarkably convoluted I cannot even figure out what it is
trying to
accomplish. The spontaneous ReleaseCapture calls seem to indicate serious
problems.
Explain what this code is trying to accomplish. Then rewrite it so it
accomplishes it.
But the entire inner loop has to go.
*****
for (;;)
{
MSG msg;
::GetMessage(&msg,NULL,0,0);
CWnd *pwnd = AfxGetApp()->GetMainWnd();
HWND hwnd = pwnd->GetSafeHwnd();
switch(msg.message)
{
case WM_MOUSEMOVE:
RECT rc;
bMove = TRUE;
pt = msg.lParam ;
GetWindowRect(&rc);
if(PtInRect(&rc,pt))
{
SetTimer(TID_POLLMOUSE,MOUSE_POLL_DELAY,NULL);
if(hwnd != GetCapture()->GetSafeHwnd() )
{
SetCapture();
}
break;
}
break;
case WM_LBUTTONUP:
if(bMove)
{
bMove = FALSE;
AfxMessageBox("Mouse L-Button UP, After Mouse Move.");
}
else
AfxMessageBox("Mouse L-Button UP.");
ReleaseCapture();
KillTimer(TID_POLLMOUSE);
PostMessage(WM_MOUSELEAVE,0,0L);
break;
case WM_TIMER:
GetWindowRect(&rc);
GetCursorPos(&pt);
if(PtInRect(&rc,pt))
{
PostMessage(WM_MOUSEHOVER,0,0L);
break;
}
ReleaseCapture();
KillTimer(TID_POLLMOUSE);
PostMessage(WM_MOUSELEAVE,0,0L);
break;
default:
DispatchMessage(&msg);
}//End of switch
// release the mouse (if we still own it)
if (GetCapture() == this) ::ReleaseCapture();
}//End of For
CView::OnLButtonDown(nFlags, point);
}
Joseph M. Newcomer [MVP]
email: newcomer@flounder.com
Web: http://www.flounder.com
MVP Tips: http://www.flounder.com/mvp_tips.htm