Re: variant memory leak
PaulH <paul.heil@gmail.com> wrote:
I have a COM object with the interface IMyInterface and a function
GetDataList(), as below. But, when I go to use the GetDataList()
function, as in SomeFunction(), I have a memory leak.
Can anybody point out to me where my problem is?
Also, if there's an obviously more efficient way to implement the
GetDataList() function, please feel free to point it out to me.
STDMETHODIMP CMyInterface::GetDataList(VARIANT * list)
{
//Init
VariantInit(list);
VariantClear(list);
A VariantClear call is pointless after a VariantInit: since the variant
is already empty, VariantClear does nothing.
//copy safearray to return value
CComVariant vtReturnVal(data.Detach());
return vtReturnVal.Detach(list);
This leaks. CComVariant's constructor makes a copy of the SAFEARRAY, but
the original is detached from its CComSafeArray wrapper so nobody is
responsible for it anymore, and it does not get freed. Make it
V_VT(list) = VT_UI1 | VT_ARRAY;
V_ARRAY(list) = data.Detach();
--
With best wishes,
Igor Tandetnik
With sufficient thrust, pigs fly just fine. However, this is not
necessarily a good idea. It is hard to be sure where they are going to
land, and it could be dangerous sitting under them as they fly
overhead. -- RFC 1925