Re: Audit
On Jul 8, 4:03 pm, Jonathan Lee <cho...@shaw.ca> wrote:
On Jul 8, 5:26 am, James Kanze <james.ka...@gmail.com> wrote:
The only #if's that code should contain are include guards
(which should normally automatically be inserted by the editor).
Non-portable code belongs in a separate file, in a target
dependent directory.
What do you recommend for this scenario: I have a project
which uses the Qt libraries. From version 3 to version 4
of Qt there were many changes to the API, so my code has
a lot of this:
#ifndef QT_V3
statusbar->addPermanentWidget(ageLabel);
#else
statusbar->addWidget(ageLabel, true);
#endif
I would like to support both versions, but having two
separate cpp files for these little one liners seems
difficult to maintain. Having one file, I figure,
allows me to keep the two versions in step.
You don't necessarily need two separate source files. Just two
headers, with something like:
inline void
addPermanentWidget(
QT_StatusBar* statusBar,
std::string const& label )
{
statusBar->addWidget( label, true ) ;
}
in one, and:
inline void
addPermanentWidget(
QT_StatusBar* statusBar,
std::string const& label )
{
statusBar->addPermanentWidget( label ) ;
}
in the other. Put them in separate directories, and choose
which one by means of a -I option at compile time. Or wrap the
interface any other way you like.
(Of course, one might also consider changing suppliers
completely. Breaking client code in this manner is pretty
irresponsible, and I'd wonder about a supplier who cared so
little for his customers.)
--
James Kanze (GABI Software) email:james.kanze@gmail.com
Conseils en informatique orient=E9e objet/
Beratung in objektorientierter Datenverarbeitung
9 place S=E9mard, 78210 St.-Cyr-l'=C9cole, France, +33 (0)1 30 23 00 34