Re: I'm a newbie. Is this code ugly?

From:

Richard Herring <junk@[127.0.0.1]>

Newsgroups:

comp.lang.c++

Date:

Thu, 21 Jan 2010 13:49:08 +0000

Message-ID:

<FLTpfxBUtFWLFwWP@baesystems.com>

In message <4b57ff58$0$1135$4fafbaef@reader1.news.tin.it>, io_x
<a@b.c.invalid> writes

"Richard Herring" <junk@[127.0.0.1]> ha scritto nel messaggio
news:eVoPozi2GzVLFwND@baesystems.com...

In message <4b57269b$0$1132$4fafbaef@reader1.news.tin.it>, io_x
<a@b.c.invalid> trolled

"Richard Herring" <junk@[127.0.0.1]> ha scritto nel messaggio
news:4iB21VKQpuVLFw7l@baesystems.com...

In message <4b56d0c2$0$828$4fafbaef@reader5.news.tin.it>, io_x
<a@b.c.invalid>
writes

"gert" <27hiro@googlemail.com> ha scritto nel messaggio
news:e4951ec7-f09b-4b74-9cf8-a7a9e19e400c@22g2000yqr.googlegroups.com...

I'm using a class which can sinksort an array of it's own objects and
an example T class, which can have names and stuff...
I was in doubt about what to do about nearly any line, so I would love
any of your recommendations...

what about this?

Horrible.

This code works, after a fashion, because those strings are all literals.
What
would happen if you were reading values from a file?

no problem, i make local copy

Still horrible.

#include <iostream>
#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>
#define R return

Using macros to represent language keywords is inexcusable obfuscation. Are
you J*ff R*lf?

using namespace std;

char* faiMemCopia(char* v)

Why are you (badly) reinventing strcpy() ?

{int i, n;
char *p;
if(v==0) R 0;
n=strlen(v);
if(n<=0) R 0;

Why? There's nothing intrinsically wrong with a zero-length string.

yes here i would say "if(n<0) R 0;"

And under what circumstances would strlen() ever return a negative
value?

[...]

int alloca(char *num, char *key, char *surname)

This sets up the class invariant. Put it in a constructor.

here i have one array of T* ;
the problem is always the same:
i have a class Y
Y *p;
p is class pointer
than i want build for p the Y class
than i don't know how use constructor-destructor for Y for that object

what i can do is
p=(Y*) malloc(sizeof(Y));
p->inizialize();
and
for deallocate it
p->deinizialize();
free(p);

The C++ way to do that is:

p = new Y;
/* ... */

delete p;

and the constructor and destructor of Y will be called without any work
on your part.

--
Richard Herring