Re: A style question on const char* vs. std::string
Ulrich Eckhardt wrote:
Zeljko Vrba wrote:
class transaction_ticket {
private:
static titles_map& titles;
static titles_map& get_titles();
...
};
titles_map& transaction_ticket::titles = get_titles(); [*]
titles_map& transaction_ticket::get_titles()
{
static titles_map titles;
[...]
return titles;
}
This code is broken. [...]
Now, the problem here is that someone was trying to be smart and make the
syntax a bit more convenient by simply binding the returnvalue of that
function in a reference. However, doing that he also introduced another
global object which again suffers the undefined initialisation order.
So, which exactly is the error? The fact that titles (the data member)
is a reference, not an object?
The reference that get_titles() returns is to a static object, which is
initialised at the first call to get_titles() and persists until the end
of the program, and titles (the data member) is a reference to it.. so I
can't see what could be a problem here.
In addition, I don't see any "global object" that you say he introduced,
even in class scopes; the only object I see is titles in a local scope.
--
Seungbeom Kim
[ See http://www.gotw.ca/resources/clcm.htm for info about ]
[ comp.lang.c++.moderated. First time posters: Do this! ]