Re: unable to set font name for CRichEditCtrl

From:

=?Utf-8?B?bmV4b2xpdGU=?= <nexolite@discussions.microsoft.com>

Newsgroups:

microsoft.public.vc.mfc

Date:

Sat, 10 Jan 2009 10:55:01 -0800

Message-ID:

<9E78F2C6-E32B-4304-B26E-C7829DBB9243@microsoft.com>

Thanks a lot ..
as you said I did the following

CFontDialog dlg;
LOGFONT lf;
    if(dlg.DoModal()==IDOK)
    {
        dlg.GetCurrentFont(&lf);
        CFont font;
        font.CreateFontA(lf.lfHeight,lf.lfWidth,lf.lfEscapement,lf.lfOrientation,lf.lfWidth,lf.lfItalic,lf.lfUnderline,lf.lfStrikeOut,lf.lfCharSet,lf.lfOutPrecision,lf.lfClipPrecision,lf.lfQuality,lf.lfPitchAndFamily,lf.lfFaceName);
        ChatWindow.SetFont(&font);
    }

I was able to set the font after this, but how do I set the color of the text?
and is it ok or anything much better can be done?
   ChatWindow.Attach(GetDlgItem(IDC_CHATWINDOW)->m_hWnd);



"Joseph M. Newcomer" wrote:

There are many things wrong here
On Sat, 10 Jan 2009 04:27:01 -0800, nexolite <nexolite@discussions.microsoft.com> wrote:

I have done the following to set the font for CRichEditCtrl which was
selected through a CFontDialog:

    CFontDialog dlg;

    if(dlg.DoModal()==IDOK)
    {
        dlg.GetCurrentFont(&lf);
        strcpy(chf.szFaceName,lf.lfFaceName);

****
ARGH! strcpy is obsolete, dangerous, and deprecated. DO NOT USE IT! The correct code,
but which you wouldn't execute here, is
_tcscpy_s(chf.szFaceName, LF_FACESIZE, lf.lfFaceName);
Would it have inconvenienced you to have shown the declarations of lf and chf? How are we
supposed to know what these are? Ethereal vibrations?

All str functions should be thought of as obsolete. We no longer live in an 8-bit world.
But strcpy and strcat are not only obsolete, they should never, ever, be used.
*****

chf.dwMask = CFM_STRIKEOUT|CFM_BOLD;

****
WHITESPACE! Put whitespace around binary operators!
****

         chf.dwEffects = CFE_BOLD;
        CString str=chf.szFaceName;

        MessageBox(str); // Displays Correct font(that was selected)

        ChatWindow=(CRichEditCtrl*)GetDlgItem(IDC_RICHEDIT23);

*****
WHy are you using something as obsolete as GetDlgItem here? Why did you not declare a
control variable? Why did you use some weird name like IDC_RICHEDIT23 instead of some
meaningful name like IDC_CHATWINDOW?
*****

ChatWindow->SetSelectionCharFormat(chf);

*****
You are setting the selection character format, but you seem to have missed establishing
how the selection is set. Without knowing what the selection is, there's no way to tell
what this is doing.
****

         #ifdef _DEBUG
        ChatWindow->GetSelectionCharFormat(chf);
        ASSERT((chf.dwMask&(CFM_STRIKEOUT|CFM_BOLD)) ==
        (CFM_STRIKEOUT|CFM_BOLD));
        ASSERT((chf.dwEffects&(CFE_STRIKEOUT|CFE_BOLD)) == CFE_BOLD);
        str=chf.szFaceName;

        MessageBox(str); //Always displays MS Sans Serif

        ASSERT((strcmp(chf.szFaceName,lf.lfFaceName)==0)); //and the assertion
fails
        #endif
    }

*****
But that doesn't answer the question about what is going to happen if you put text out at
this point. Note that setting the selection font does not set the font for the control,
just for the selection. Did you try SetFont if you want to change the font for the entire
control?
joe
****

why this is not working properly?

Joseph M. Newcomer [MVP]
email: newcomer@flounder.com
Web: http://www.flounder.com
MVP Tips: http://www.flounder.com/mvp_tips.htm